[ 
https://issues.apache.org/jira/browse/MINIFICPP-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636887#comment-16636887
 ] 

ASF GitHub Bot commented on MINIFICPP-627:
------------------------------------------

Github user phrocker commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/408
  
    Good changes. I'll perform some additional tests and merge. it seems that 
the windows build is a version issue and not related. 


> Remove unnecessary ternary operators, variable shadowing
> --------------------------------------------------------
>
>                 Key: MINIFICPP-627
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-627
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Arpad Boda
>            Assignee: Arpad Boda
>            Priority: Trivial
>
> There are some "? true : false" operations in the code, which is unnecessary. 
> Variable shadowing are to be removed to reduce the possibility of errors when 
> touching the code. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to