[
https://issues.apache.org/jira/browse/MINIFICPP-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636878#comment-16636878
]
ASF GitHub Bot commented on MINIFICPP-627:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/408#discussion_r222282701
--- Diff: thirdparty/spdlog-20170710/include/spdlog/details/os.h ---
@@ -459,9 +459,9 @@ inline bool in_terminal(FILE* file)
{
#ifdef _WIN32
- return _isatty(_fileno(file)) ? true : false;
--- End diff --
While we do have some specializations changing a third party library for
readability and not functionality might not be the most ideal if we have to
compare across versions.
> Remove unnecessary ternary operators, variable shadowing
> --------------------------------------------------------
>
> Key: MINIFICPP-627
> URL: https://issues.apache.org/jira/browse/MINIFICPP-627
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Trivial
>
> There are some "? true : false" operations in the code, which is unnecessary.
> Variable shadowing are to be removed to reduce the possibility of errors when
> touching the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
