Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/416#discussion_r223391414
  
    --- Diff: libminifi/include/capi/api.h ---
    @@ -138,6 +138,8 @@ flow *create_flow(nifi_instance *, const char *);
     
     flow *create_getfile(nifi_instance *instance, flow *parent, GetFileConfig 
*c);
     
    +uint8_t add_processor(flow *parent_flow, const char *proc_name, const char 
*config);
    --- End diff --
    
    If we use processor name here this seems less explicit than returning a 
processor on which we purposefully set the config. What is config here in this 
case? 


---

Reply via email to