Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/416#discussion_r223405945
--- Diff: libminifi/include/capi/Plan.h ---
@@ -79,6 +79,8 @@ class ExecutionPlan {
return content_repo_;
}
+ static std::shared_ptr<core::Processor> createProcessor(const
std::string &processor_name, const std::string &name);
--- End diff --
This is in Plan, where addProcessor also requires name to be specified, so
the API is consistent in my opinion.
I get what you mean, but in that case I would also prefer to modify
Plan::addProcessor to have "name" as an optional argument.
---
