Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/416#discussion_r223412104
  
    --- Diff: libminifi/src/capi/api.cpp ---
    @@ -287,6 +288,41 @@ flow *create_getfile(nifi_instance *instance, flow 
*parent_flow, GetFileConfig *
       return new_flow;
     }
     
    +/**
    + * Adds processor to existing flow
    + * @param proc_name: name of the new processor
    + * @param config: config of the processor, key=value pairs separated by ';'
    + * @return:
    + *   -0: success
    + *   -1: processor cannot be instanciated
    + *   -2: invalid config string
    + *   -3: invalid property name in config string
    + */
    +uint8_t add_processor(flow *parent_flow, const char *proc_name, const char 
*config) {
    --- End diff --
    
    Sorry I see that more as a helper. If we're going down that route we should 
probably define more strongly typed configs and put that just outside of the 
core API 


---

Reply via email to