[
https://issues.apache.org/jira/browse/NIFI-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652513#comment-16652513
]
ASF GitHub Bot commented on NIFI-5711:
--------------------------------------
GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/3085
NIFI-5711 NLKBufferedReader appears extend and copy portions of the J…
…DK BufferedReader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-5711
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3085
----
commit d0d9f0172839e62cf624fe1801f8f532d42a783d
Author: patricker <patricker@...>
Date: 2018-10-16T21:56:55Z
NIFI-5711 NLKBufferedReader appears extend and copy portions of the JDK
BufferedReader
----
> NLKBufferedReader appears extend and copy portions of the JDK BufferedReader
> ----------------------------------------------------------------------------
>
> Key: NIFI-5711
> URL: https://issues.apache.org/jira/browse/NIFI-5711
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Joseph Witt
> Assignee: Mark Payne
> Priority: Blocker
> Fix For: 1.8.0
>
>
> NLKBufferedReader appears to extend from then copy then alter JDK code.
> Extension and alter is fine. Copy and paste to get there is not. The JDK
> code is not licensed in a manner conducive for ALv2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
