[
https://issues.apache.org/jira/browse/NIFI-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653702#comment-16653702
]
ASF GitHub Bot commented on NIFI-5711:
--------------------------------------
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/3085
@patricker thanks for the submission! I did a code review and everything
looks correct to me. I did some testing and verified everything. However, I did
notice difference in performance between this PR and 1.7.1. I have created a
new JIRA to track that so that it can be addressed in the future. However,
since the scope of the performance change is limited, I think that it makes
sense to merge this as-is and allow 1.8.0 release process to continue and then
can improve performance afterwards. +1 merged to master. Thanks again!
> NLKBufferedReader appears extend and copy portions of the JDK BufferedReader
> ----------------------------------------------------------------------------
>
> Key: NIFI-5711
> URL: https://issues.apache.org/jira/browse/NIFI-5711
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Joseph Witt
> Assignee: Mark Payne
> Priority: Blocker
> Fix For: 1.8.0
>
>
> NLKBufferedReader appears to extend from then copy then alter JDK code.
> Extension and alter is fine. Copy and paste to get there is not. The JDK
> code is not licensed in a manner conducive for ALv2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
