[ 
https://issues.apache.org/jira/browse/NIFI-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653820#comment-16653820
 ] 

ASF GitHub Bot commented on NIFI-5711:
--------------------------------------

Github user patricker commented on the issue:

    https://github.com/apache/nifi/pull/3085
  
    @markap14 Thanks Mark. One thing I didn't test, and I don't know if it's 
covered by the current test suite, is very long lines. I didn't think about it 
until this morning, but with the way I re-wrote this, if a file has a single 
very long line I don't think it will fail when the length of the line exceeds 
the buffer; which is what the docs say should happen. This is because I just 
call `read()`, and read handles keeping the buffer filled... 


> NLKBufferedReader appears extend and copy portions of the JDK BufferedReader
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-5711
>                 URL: https://issues.apache.org/jira/browse/NIFI-5711
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Mark Payne
>            Priority: Blocker
>             Fix For: 1.8.0
>
>
> NLKBufferedReader appears to extend from then copy then alter JDK code.  
> Extension and alter is fine.  Copy and paste to get there is not.  The JDK 
> code is not licensed in a manner conducive for ALv2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to