phrocker commented on a change in pull request #550: MINIFICPP-822 - Nanofi raw S2S implementation shouldn't depend on any… URL: https://github.com/apache/nifi-minifi-cpp/pull/550#discussion_r282462842
########## File path: libminifi/src/io/posix/ClientSocket.cpp ########## @@ -59,7 +59,7 @@ Socket::Socket(const std::shared_ptr<SocketContext> &context, const std::string FD_ZERO(&read_fds_); } -Socket::Socket(const std::shared_ptr<SocketContext> &context, const std::string &hostname, const uint16_t port) +Socket::Socket(const std::shared_ptr<SocketContext>& context, const std::string &hostname, const uint16_t port) Review comment: Ah if you have a chance can you add something to constructor's document block, too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
