phrocker commented on a change in pull request #550: MINIFICPP-822 - Nanofi raw
S2S implementation shouldn't depend on any…
URL: https://github.com/apache/nifi-minifi-cpp/pull/550#discussion_r284316977
##########
File path: nanofi/include/core/cstructs.h
##########
@@ -136,6 +141,12 @@ typedef struct file_buffer {
uint64_t file_len;
} file_buffer;
-typedef struct cstream cstream;
+#ifndef _WIN32
Review comment:
Hmm _WIN32 can be compiler specific and potentially not defined
appropriately on all compilers (but I don't know if we will ever hit it with
mingw or any others ), to be safe we define WIN32 via CMAKE which does the
compiler general checks for minifi. While this is against the norm in minifi, I
don't have any strong feelings in nanofi. It will may be broken apart and have
different conventions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
