phrocker commented on a change in pull request #550: MINIFICPP-822 - Nanofi raw
S2S implementation shouldn't depend on any…
URL: https://github.com/apache/nifi-minifi-cpp/pull/550#discussion_r284290207
##########
File path: libminifi/src/io/DescriptorStream.cpp
##########
@@ -84,11 +84,10 @@ int DescriptorStream::readData(uint8_t *buf, int buflen) {
if (!IsNullOrEmpty(buf)) {
auto size_read = ::read(fd_, buf, buflen);
- if (size_read != buflen) {
+ if (size_read < 0) {
Review comment:
Hmm, I know customers have previously used this functionality successfully
-- but I also know something broke along the way ( haven't had time to
investigate ). What was the chief problem that you saw? Is this a necessary
part of this PR? If not can we improve testing on the piece it visits (
preferably in a separate PR, so this can be merged asap ). With a bug we can
certainly change behavior, but we need those tests to prove that bug impacts
whatever uses this and a separate PR would be preferred since that seems
unrelated to this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
