thenatog commented on a change in pull request #3482: NIFI-6280 - Broke out the
matching for /access/knox/** and /access/oi…
URL: https://github.com/apache/nifi/pull/3482#discussion_r285743971
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtAuthenticationFilter.java
##########
@@ -43,15 +46,27 @@ public Authentication attemptAuthentication(final
HttpServletRequest request) {
// TODO: Refactor request header extraction logic to shared utility as
it is duplicated in AccessResource
// get the principal out of the user token
- final String authorization = request.getHeader(AUTHORIZATION);
+ final String authentication = request.getHeader(AUTHORIZATION);
Review comment:
I changed this because "Authorization" as a header name for containing
authentication credentials is misleading (a historically bad HTTP header name).
At the first opportunity in code I thought if I changed this instead to use a
variable named authentication, the rest of the code can be read as
'authentication'. I can change this back though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
