thenatog commented on a change in pull request #3482: NIFI-6280 - Broke out the
matching for /access/knox/** and /access/oi…
URL: https://github.com/apache/nifi/pull/3482#discussion_r286134486
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/ProxiedEntitiesUtils.java
##########
@@ -148,13 +147,13 @@ public static String
buildProxiedEntitiesChainString(final NiFiUser user) {
return StringUtils.join(proxyChain, "");
}
- public static void successfulAuthorization(HttpServletRequest request,
HttpServletResponse response, Authentication authResult) {
+ public static void successfulAuthentication(HttpServletRequest request,
HttpServletResponse response) {
Review comment:
Made a mistake with that first comment:
```
/**
* If a successfully authenticated request was made via a proxy, relevant
proxy headers will be added to the response.
*
* @param request The proxied client request that was successfully
authenticated.
* @param response A servlet response to the client containing the successful
authentication details.
*/
public static void successfulAuthentication(HttpServletRequest request,
HttpServletResponse response) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
