thenatog commented on a change in pull request #3482: NIFI-6280 - Broke out the
matching for /access/knox/** and /access/oi…
URL: https://github.com/apache/nifi/pull/3482#discussion_r286092332
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/ProxiedEntitiesUtils.java
##########
@@ -148,13 +147,13 @@ public static String
buildProxiedEntitiesChainString(final NiFiUser user) {
return StringUtils.join(proxyChain, "");
}
- public static void successfulAuthorization(HttpServletRequest request,
HttpServletResponse response, Authentication authResult) {
+ public static void successfulAuthentication(HttpServletRequest request,
HttpServletResponse response) {
Review comment:
Are these correct?:
```
/**
* If using a proxy, tell the proxy the proxied user identity was
authenticated.
*
* @param request The original client request that failed to be authenticated.
* @param response Servlet response to the client containing the successful
authentication details.
*/
```
/**
* If using a proxy, give the proxy an explanation why authentication
failed.
*
* @param request The proxied client request that failed to be
authenticated.
* @param response Servlet response to the proxied client containing the
unsuccessful authentication attempt details.
* @param failed The related exception thrown and explanation for the
unsuccessful authentication attempt.
*/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
