phrocker commented on a change in pull request #563: WiP: MINIFICPP-839 - Fix
memleaks
URL: https://github.com/apache/nifi-minifi-cpp/pull/563#discussion_r286028878
##########
File path: libminifi/src/core/repository/VolatileContentRepository.cpp
##########
@@ -81,10 +81,7 @@ void VolatileContentRepository::start() {
return;
if (running_)
return;
- thread_ = std::thread(&VolatileContentRepository::run,
shared_from_parent<VolatileContentRepository>());
- thread_.detach();
Review comment:
What was the point of removing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
