phrocker commented on a change in pull request #563: WiP: MINIFICPP-839 - Fix
memleaks
URL: https://github.com/apache/nifi-minifi-cpp/pull/563#discussion_r286029938
##########
File path: libminifi/src/ResourceClaim.cpp
##########
@@ -41,11 +42,15 @@ void setDefaultDirectory(std::string path) {
default_directory_path = path;
}
-ResourceClaim::ResourceClaim(std::shared_ptr<core::StreamManager<ResourceClaim>>
claim_manager)
Review comment:
These claims should not be persisted on stops. They should complete, so
making them weak seems counterintuitive, though I admit it may be necessary --
why is the claim required to be weak ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
