phrocker commented on a change in pull request #563: WiP: MINIFICPP-839 - Fix 
memleaks
URL: https://github.com/apache/nifi-minifi-cpp/pull/563#discussion_r286030072
 
 

 ##########
 File path: libminifi/src/core/ProcessSession.cpp
 ##########
 @@ -805,7 +805,7 @@ void ProcessSession::commit() {
         continue;
       }
 
-      connection = 
std::static_pointer_cast<Connection>(record->getConnection());
+      connection = 
std::static_pointer_cast<Connection>(record->getConnection().lock());
 
 Review comment:
   Session should be a hard pointer. How did you arrive at this? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to