turcsanyip commented on a change in pull request #3504: NIFI-6318: Support EL
in CSV formatting properties
URL: https://github.com/apache/nifi/pull/3504#discussion_r291546803
##########
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-service-api/src/main/java/org/apache/nifi/serialization/RecordSetWriterFactory.java
##########
@@ -77,4 +77,24 @@
* @throws IOException if unable to read from the given InputStream
*/
RecordSetWriter createWriter(ComponentLog logger, RecordSchema schema,
OutputStream out) throws SchemaNotFoundException, IOException;
+
+ /**
+ * <p>
+ * Creates a new RecordSetWriter that is capable of writing record
contents to an OutputStream.
+ * This version of the overloaded method accepts a variables map that can
be used to resolve properties specified via Expression Language.
+ * The default implementation simply discards the variables map and
delegates the call to {@link #createWriter(ComponentLog, RecordSchema,
OutputStream)}.
+ * </p>
+ *
+ * @param logger the logger to use when logging information. This is
passed in, rather than using the logger of the Controller Service
+ * because it allows messages to be logged for the component
that is calling this Controller Service.
+ * @param schema the schema that will be used for writing records
+ * @param out the OutputStream to write to
+ * @param variables the variables which is used to resolve properties
specified via Expression Language
+ *
+ * @return a RecordSetWriter that can write record sets to an OutputStream
+ * @throws IOException if unable to read from the given InputStream
+ */
+ default RecordSetWriter createWriter(ComponentLog logger, RecordSchema
schema, OutputStream out, Map<String, String> variables) throws
SchemaNotFoundException, IOException {
Review comment:
I chose method overloading in order to keep backward compatibility (3rd
party / custom components).
In our code we could use the new signature everywhere. I will change the
calls to pass the FF attributes or empty map if no FF available.
At the same time I can delete the old method or make it deprecated (and
delete it later).
@ijokarumawak: which one would you prefer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
