phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r297088948
##########
File path: cmake/BuildTests.cmake
##########
@@ -76,10 +76,12 @@ function(createTests testName)
endif()
target_link_libraries(${testName} ${CMAKE_DL_LIBS} ${SPD_LIB}
${TEST_BASE_LIB})
target_link_libraries(${testName} ${CMAKE_THREAD_LIBS_INIT} core-minifi
yaml-cpp)
- #${OPENSSL_LIBRARIES}
if (NOT excludeBase)
if (APPLE)
target_link_libraries (${testName} -Wl,-all_load minifi)
+ elseif(WIN32)
+ target_link_libraries (${testName} minifi)
+ set_target_properties(${testName} PROPERTIES LINK_FLAGS
"${LINK_FLAGS} /WHOLEARCHIVE:minifi")
Review comment:
We should use wholearchive judiciously....not sure if this is a case where
this needs to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
