phrocker commented on a change in pull request #596: MINIFICPP-925 - Fix
TailFile hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r296828333
##########
File path: libminifi/include/core/ProcessSession.h
##########
@@ -109,8 +109,8 @@ class ProcessSession : public ReferenceContainer {
*/
void importFrom(io::DataStream &stream, const
std::shared_ptr<core::FlowFile> &flow);
// import from the data source.
- void import(std::string source, const std::shared_ptr<core::FlowFile> &flow,
bool keepSource = true, uint64_t offset = 0);
- void import(std::string source, std::vector<std::shared_ptr<FlowFileRecord>>
&flows, bool keepSource, uint64_t offset, char inputDelimiter);
Review comment:
You're changing the contract. We will need to keep the
(...bool,uint64_t,char) variant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
