phrocker commented on a change in pull request #596: MINIFICPP-925 - Fix 
TailFile hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r296832716
 
 

 ##########
 File path: libminifi/src/utils/StringUtils.cpp
 ##########
 @@ -0,0 +1,162 @@
+/**
 
 Review comment:
   Actually, this looks a little different and may not have the same linking 
issues but I'm -1 on this in this PR. Can you submit this into a separate PR so 
it can be prioritized whether we should include this into this release? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to