phrocker commented on a change in pull request #596: MINIFICPP-925 - Fix
TailFile hang on long lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r296831972
##########
File path: extensions/standard-processors/processors/HashContent.h
##########
@@ -72,7 +64,7 @@ namespace {
if (ret_val.second > 0) {
unsigned char digest[MD5_DIGEST_LENGTH];
MD5_Final(digest, &context);
- ret_val.first = digestToString(digest, MD5_DIGEST_LENGTH);
+ ret_val.first = utils::StringUtils::to_hex(digest, MD5_DIGEST_LENGTH,
true /*uppercase*/);
Review comment:
ditto here, too. If you wish submit the to_hex pr changing variants let's
get that as a separate PR so we can accurately prioritize its review. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
