mcgilman commented on a change in pull request #3536: NIFI-6380: Introduced the
notion of Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#discussion_r300016677
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/flow/StandardFlowManager.java
##########
@@ -582,7 +591,11 @@ public void removeReportingTask(final ReportingTaskNode
reportingTaskNode) {
ReflectionUtils.quietlyInvokeMethodsWithAnnotation(OnRemoved.class,
reportingTaskNode.getReportingTask(),
reportingTaskNode.getConfigurationContext());
}
- for (final Map.Entry<PropertyDescriptor, String> entry :
reportingTaskNode.getProperties().entrySet()) {
+ // TODO: Probably should create a method on ComponentNode:
`List<ControllerServiceNode> getReferencedControllerServices()` This same code
block (or something similar)
+ // is scattered all throughout the codebase. If we look at references
to ComponentNode.getEffectivePropertyValues(), it will show the same thing over
& over.
+ // ALSO - double-check what happens if we have a component reference
Controller Service A two times - here we would remove the reference twice, but
do we add the reference
+ // twice? If not, we need to address that!
Review comment:
Are these things that you still need to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
