mcgilman commented on a change in pull request #3536: NIFI-6380: Introduced the
notion of Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#discussion_r300057978
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/processor/StandardProcessContext.java
##########
@@ -53,28 +53,37 @@
private final Map<PropertyDescriptor, String> properties;
public StandardProcessContext(final ProcessorNode processorNode, final
ControllerServiceProvider controllerServiceProvider, final StringEncryptor
encryptor, final StateManager stateManager,
- final TaskTermination taskTermination) {
+ final TaskTermination taskTermination) {
this.procNode = processorNode;
this.controllerServiceProvider = controllerServiceProvider;
this.encryptor = encryptor;
this.stateManager = stateManager;
this.taskTermination = taskTermination;
+ properties =
Collections.unmodifiableMap(processorNode.getEffectivePropertyValues());
+
preparedQueries = new HashMap<>();
- for (final Map.Entry<PropertyDescriptor, String> entry :
procNode.getProperties().entrySet()) {
+ for (final Map.Entry<PropertyDescriptor, String> entry :
processorNode.getRawPropertyValues().entrySet()) {
final PropertyDescriptor desc = entry.getKey();
String value = entry.getValue();
if (value == null) {
value = desc.getDefaultValue();
}
if (value != null) {
+// final List<Range> ranges =
Query.extractExpressionRanges(value);
+//
+// final PreparedQuery pq;
+// if (ranges.isEmpty()) {
+// pq = EmptyPreparedQuery.forText(properties.get(desc));
+// } else {
+// pq = Query.prepare(value);
+// }
+
Review comment:
Is this commented out code no longer needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
