mcgilman commented on a change in pull request #3536: NIFI-6380: Introduced the
notion of Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#discussion_r300016840
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/flow/StandardFlowManager.java
##########
@@ -638,7 +651,8 @@ public void removeRootControllerService(final
ControllerServiceNode service) {
ReflectionUtils.quietlyInvokeMethodsWithAnnotation(OnRemoved.class,
service.getControllerServiceImplementation(), configurationContext);
}
- for (final Map.Entry<PropertyDescriptor, String> entry :
service.getProperties().entrySet()) {
+ // TODO: Again - add getReferencedControllerServices() method. It
would be more efficient than this, calculating the effective property values
every time.
Review comment:
And this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
