phrocker commented on a change in pull request #610: MINIFICPP-814 - Fixed
ListenHTTP and HTTPClient bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r304569560
##########
File path: extensions/http-curl/client/HTTPClient.cpp
##########
@@ -265,36 +324,6 @@ bool HTTPClient::submit() {
}
logger_->log_debug("Finished with %s", url_);
- std::string key = "";
Review comment:
The more I think about it, I created
https://issues.apache.org/jira/browse/MINIFICPP-981. Would love to hear your
thoughts on that. curl bugs because we moved fast and loose with a limited
number of devs means we're going to have more bugs. Even if people come around
and locate them we still have a lot of risk because CURL has a large and
constantly evolving API. curlpp has dedicated their project to an http client
and I'd love to stop the maintenance of that and instead only wrap it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
