phrocker commented on a change in pull request #610: MINIFICPP-814 - Fixed 
ListenHTTP and HTTPClient bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r304560605
 
 

 ##########
 File path: extensions/http-curl/client/HTTPClient.cpp
 ##########
 @@ -120,8 +120,21 @@ void HTTPClient::forceClose() {
 
 }
 
+int HTTPClient::debug_callback(CURL *handle, curl_infotype type, char *data, 
size_t size, void *userptr) {
 
 Review comment:
   I totally agree and love this, I've used CURLOPT_DEBUGDATA on other projects 
with a logger and a flag that allows me to separate this output from the 
logger. That may be useful here so that logs ( of http client ) are separate 
from the curl output. This could be by way of setVerbose(flag) to indicate go 
to logger or stdout/stderr. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to