MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add
padLeft() and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r314947147
##########
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##########
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
- public static String padLeft(final String source, int length, char
padding) {
- if (source != null) {
+ public static String padLeft(final String source, int length, String
padding) {
Review comment:
I think that's the appropriate behavior here in case the underlying
libraries for some odd reason have a problem. We don't want people losing the
original data altogether.
The reason I asked about the commons-lang3 issue is that if you did derive
it from code from commons-lang3 I need to do a license and notice check to make
sure that the IP legal blurbs are up to date. It's basically legal, not
technical. So when you say inspired is that "you wrote it yourself based on
ideas you got" or "I did copy and paste and maybe some tweaks?"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
