MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add
padLeft() and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315278981
##########
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##########
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
- public static String padLeft(final String source, int length, char
padding) {
- if (source != null) {
+ public static String padLeft(final String source, int length, String
padding) {
Review comment:
@adarmiento Joe wants to avoid the dependency for now:
> If we want to avoid a binary dependency (**and I think we do** given that
we have our own StringUtil in this module for this purpose [*Emphasis mine* -
Mike]
So feel free to just copy the left/right pad methods from `commons-lang3`
into our `StringUtils` and add the Javadoc lines I gave you. I'll take a look
at the LICENSE and NOTICE files at the root level and give you any updates I
think you need to add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
