MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add 
padLeft() and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315416196
 
 

 ##########
 File path: 
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
 ##########
 @@ -78,25 +78,63 @@ public static String join(final Collection collection, 
String delimiter) {
         return sb.toString().substring(0, sb.lastIndexOf(delimiter));
     }
 
-    public static String padLeft(final String source, int length, char 
padding) {
-        if (source != null) {
+    public static String padLeft(final String source, int length, String 
padding) {
 
 Review comment:
   I think we can leave them as-is. We have the top level attribution for the 
code, so I'm going to merge. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to