tpalfy commented on a change in pull request #3748: NIFI-6680: Nifi PutKudu processor - Convert record field names to low… URL: https://github.com/apache/nifi/pull/3748#discussion_r326260268
########## File path: nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/TestPutKudu.java ########## @@ -412,6 +413,7 @@ private void buildPartialRow(Long id, String name, Short age) { kuduSchema.newPartialRow(), new MapRecord(schema, values), schema.getFieldNames(), + true, Review comment: I think setting `lowercaseFields` to `true` is a bit misleading. At the moment this only works because 1. All the `fieldNames` in the test are already in lower case. 2. There are no assertions that the `buildPartialRow` actually did set the values correctly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services