tpalfy commented on a change in pull request #3748: NIFI-6680: Nifi PutKudu
processor - Convert record field names to low…
URL: https://github.com/apache/nifi/pull/3748#discussion_r327647183
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKuduProcessor.java
##########
@@ -166,15 +166,18 @@ public void shutdown() throws Exception {
}
@VisibleForTesting
- protected void buildPartialRow(Schema schema, PartialRow row, Record
record, List<String> fieldNames, Boolean ignoreNull) {
-
+ protected void buildPartialRow(Schema schema, PartialRow row, Record
record, List<String> fieldNames, Boolean ignoreNull, Boolean lowercaseFields) {
for (String colName : fieldNames) {
+ String recordFieldName = colName;
Review comment:
I know it's kinda minor, but I think this way it would be really less
confusing and more consistent:
```java
...
for (String recordFieldName : fieldNames) {
String colName = recordFieldName;
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
