tpalfy commented on a change in pull request #3748: NIFI-6680: Nifi PutKudu
processor - Convert record field names to low…
URL: https://github.com/apache/nifi/pull/3748#discussion_r327655875
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/TestPutKudu.java
##########
@@ -366,54 +368,219 @@ public void testUpdateFlowFiles() throws Exception {
@Test
public void testBuildRow() {
- buildPartialRow((long) 1, "foo", (short) 10);
+ final Schema kuduSchema = new Schema(Arrays.asList(
Review comment:
There's quite a few code duplication here. Not sure why even the existing
abstraction was replaced with code duplication.
Also it might be better for tests to be as thin and focused as possible so
that it's easier to understand _what_ and _how_ is being tested and to know
what went wrong when the test fails.
To test different types we indeed need a more complex schema.
But to test only the lowercase functionality, a simply schema with a single
field would be enough (unless the the logic _depends_ on the type of the field).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
