kjmccarthy commented on a change in pull request #3748: NIFI-6680: Nifi PutKudu
processor - Convert record field names to low…
URL: https://github.com/apache/nifi/pull/3748#discussion_r326778551
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/TestPutKudu.java
##########
@@ -103,6 +103,7 @@ private void setUpTestRunner(TestRunner testRunner) throws
InitializationExcepti
testRunner.setProperty(PutKudu.KUDU_MASTERS, DEFAULT_MASTERS);
testRunner.setProperty(PutKudu.SKIP_HEAD_LINE, SKIP_HEAD_LINE);
testRunner.setProperty(PutKudu.IGNORE_NULL, "true");
+ testRunner.setProperty(PutKudu.LOWERCASE_FIELD_NAMES, "true");
Review comment:
@tpalfy, I've pushed additional unit tests to ensure behavior is as
expected. I noticed that after looking up the index for a column in the Kudu
schema, if the column isn't found, it is ignored. I'm not sure if this is
desirable behavior and I added an exception if the index lookup returns a -1.
To me it makes sense to throw an exception if the record schema doesn't match
the table schema, but this could be a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
