kjmccarthy commented on a change in pull request #3748: NIFI-6680: Nifi PutKudu
processor - Convert record field names to low…
URL: https://github.com/apache/nifi/pull/3748#discussion_r328268658
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/TestPutKudu.java
##########
@@ -366,54 +368,219 @@ public void testUpdateFlowFiles() throws Exception {
@Test
public void testBuildRow() {
- buildPartialRow((long) 1, "foo", (short) 10);
+ final Schema kuduSchema = new Schema(Arrays.asList(
Review comment:
Since logic doesn't depend on type, I added a perimeter in the
buildPartialRow method to allow you to modify the name of the id kudu column
and id record field and modified this argument for unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
