kjmccarthy commented on a change in pull request #3748: NIFI-6680: Nifi PutKudu
processor - Convert record field names to low…
URL: https://github.com/apache/nifi/pull/3748#discussion_r326783869
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/TestPutKudu.java
##########
@@ -412,6 +413,7 @@ private void buildPartialRow(Long id, String name, Short
age) {
kuduSchema.newPartialRow(),
new MapRecord(schema, values),
schema.getFieldNames(),
+ true,
Review comment:
I'm not actually modifying the schema of the row, I'm only converting the
column name to lowercase before it looks up the index in the table schema, from
there, the column is referenced by it's index rather than the column name so I
don't think adding an assertion that row's column names are lowercase makes
sense for testing this.
Since Kudu is case sensitive, testing that an uppercase column name returns
a value != -1 when retrieving the index and lowercaseFields == true tests the
desired functionality which is partially why I added an exception if column
index = -1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
