arpadboda commented on a change in pull request #674: Minificpp 1007 - ECU C2
integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353262079
##########
File path: extensions/coap/nanofi/coap_server.c
##########
@@ -25,6 +25,7 @@ CoapServerContext * const create_server(const char * const
server_hostname, cons
memset(server, 0x00, sizeof(CoapServerContext));
if (create_endpoint_context(&server->ctx, server_hostname, port)) {
free_server(server);
+ return NULL;
Review comment:
Can't comment there at it's not new code, but I think there is also a leak
at line 45 (not freeing endpoint when returning 0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
