arpadboda commented on a change in pull request #674: Minificpp 1007 - ECU C2 
integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353260326
 
 

 ##########
 File path: extensions/coap/nanofi/coap_functions.c
 ##########
 @@ -105,12 +117,18 @@ int create_endpoint_context(coap_context_t **ctx, const 
char *node, const char *
 
       if (*ctx && ep_udp) {
         freeaddrinfo(result);
 
 Review comment:
   I would prefer just break out of the loop here instead of return, so 
resource cleanup can happen at one place. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to