arpadboda commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353279748
########## File path: nanofi/ecu/coap_server.c ########## @@ -0,0 +1,138 @@ +#include <nanofi/coap_server.h> Review comment: Multiple issues here: - License - What is the goal of this file? Are we trying to emulate a C2 server? Some comments would be nice - A server including the header of the agent is a bad smell ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
