bakaid commented on a change in pull request #715: MINIFICPP-1126 - Reduce
sawtooth in memory usage of rocksdb flowfile …
URL: https://github.com/apache/nifi-minifi-cpp/pull/715#discussion_r371693362
##########
File path: extensions/rocksdb-repos/FlowFileRepository.cpp
##########
@@ -89,23 +82,28 @@ void FlowFileRepository::flush() {
}
}
-void FlowFileRepository::run() {
- // threshold for purge
+void FlowFileRepository::printStats() {
Review comment:
If I understand correctly, this is ran every purge_period, which is, by
default, 2.5 s.
4 log lines every 2.5 seconds is way too much noise, affecting everyone, as
virtually everyone uses this FlowFileRepo and the default log level is info.
This would account for the majority of logs in many cases.
I think this should definitely be at debug level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
