bakaid commented on a change in pull request #715: MINIFICPP-1126 - Reduce
sawtooth in memory usage of rocksdb flowfile …
URL: https://github.com/apache/nifi-minifi-cpp/pull/715#discussion_r371702847
##########
File path: extensions/rocksdb-repos/FlowFileRepository.h
##########
@@ -103,6 +105,9 @@ class FlowFileRepository : public core::Repository, public
std::enable_shared_fr
options.create_if_missing = true;
options.use_direct_io_for_flush_and_compaction = true;
options.use_direct_reads = true;
+ options.write_buffer_size = 8 << 20;
Review comment:
I would like to see more in-code comments about the rationale behind these
values.
Why 8 MB? Why do we set max_write_buffer_number to 4? As far as I understand
that means it can keep 4 of these memtables in memory, and the default is 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
