bakaid commented on a change in pull request #715: MINIFICPP-1126 - Reduce 
sawtooth in memory usage of rocksdb flowfile …
URL: https://github.com/apache/nifi-minifi-cpp/pull/715#discussion_r371838409
 
 

 ##########
 File path: extensions/rocksdb-repos/FlowFileRepository.h
 ##########
 @@ -105,8 +105,15 @@ class FlowFileRepository : public core::Repository, 
public std::enable_shared_fr
     options.create_if_missing = true;
     options.use_direct_io_for_flush_and_compaction = true;
     options.use_direct_reads = true;
+
+    // Write buffers are used as db oepration logs. When they get filled the 
events are merged and serialized.
+    // The default size is 64MB.
+    // In our case it's usually too much, causing sawtooth in memory 
consumption. (Consumes more than the whole MiniFi)
+    // To avoid DB write issues during heavy load it's recommended to have 
high number of buffer.
+    // Rocksdb's stall featur can also trigger in case the number of buffers 
is >= 3.
 
 Review comment:
   typo: featur -> feature

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to