szaszm commented on a change in pull request #713: WIP: MINIFICPP-1119
MINIFICPP-1154 unify win/posix sockets + fix bugs
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r380349650
##########
File path: extensions/rocksdb-repos/RocksDbStream.h
##########
@@ -46,13 +46,7 @@ class RocksDbStream : public io::BaseStream {
* File Stream constructor that accepts an fstream shared pointer.
* It must already be initialized for read and write.
*/
- explicit RocksDbStream(const std::string &path, rocksdb::DB *db, bool
write_enable = false);
-
- /**
- * File Stream constructor that accepts an fstream shared pointer.
- * It must already be initialized for read and write.
- */
- explicit RocksDbStream(const std::string &path);
Review comment:
I don't know why I did this, will revert
edit: Realized that the removed ctor is not defined, so I'll keep it
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
