szaszm commented on a change in pull request #713: WIP: MINIFICPP-1119
MINIFICPP-1154 unify win/posix sockets + fix bugs
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r382587675
##########
File path: libminifi/src/io/StreamFactory.cpp
##########
@@ -38,35 +39,21 @@ namespace io {
template<typename T, typename V>
class SocketCreator : public AbstractStreamFactory {
- template<bool cond, typename U>
Review comment:
first introduction:
https://github.com/apache/nifi-minifi-cpp/commit/44704b363ccc422bb4fe2e1a6dcc184e9213bd68#diff-d6d59c6c5b3c0aac82860661f0e4183fR43
The intent is still unclear. Maybe it was meant to be a SFINAE check whether
`T` can be instantiated like a `Socket` can, and if not, then fall back to
`Socket`. I'm not sure, this is just a wild guess. We will get a compilation
error anyway if it's ever used like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
