szaszm commented on a change in pull request #735: MINIFICPP-1158 - Event
driven processors can starve each other
URL: https://github.com/apache/nifi-minifi-cpp/pull/735#discussion_r383873618
##########
File path: libminifi/include/utils/ThreadPool.h
##########
@@ -133,11 +107,11 @@ class Worker {
identifier_ = identifier;
}
- virtual uint64_t getTimeSlice() {
+ virtual std::chrono::time_point<std::chrono::steady_clock> getTimeSlice()
const {
return time_slice_;
}
- virtual uint64_t getWaitTime() {
+ virtual std::chrono::milliseconds getWaitTime() {
Review comment:
Can we add `const` here as well? I appreciate every improvement in
const-correctness. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
