szaszm commented on a change in pull request #735: MINIFICPP-1158 - Event
driven processors can starve each other
URL: https://github.com/apache/nifi-minifi-cpp/pull/735#discussion_r383861195
##########
File path: libminifi/include/CronDrivenSchedulingAgent.h
##########
@@ -41,16 +41,18 @@ class CronDrivenSchedulingAgent : public
ThreadedSchedulingAgent {
* Create a new event driven scheduling agent.
*/
CronDrivenSchedulingAgent(std::shared_ptr<core::controller::ControllerServiceProvider>
controller_service_provider, std::shared_ptr<core::Repository> repo,
- std::shared_ptr<core::Repository> flow_repo,
std::shared_ptr<core::ContentRepository> content_repo,
std::shared_ptr<Configure> configuration)
- : ThreadedSchedulingAgent(controller_service_provider, repo, flow_repo,
content_repo, configuration) {
+ std::shared_ptr<core::Repository> flow_repo,
std::shared_ptr<core::ContentRepository> content_repo,
std::shared_ptr<Configure> configuration,
+
std::shared_ptr<utils::ThreadPool<utils::ComplexTaskResult>> thread_pool)
+ : ThreadedSchedulingAgent(controller_service_provider, repo, flow_repo,
content_repo, configuration, thread_pool) {
}
// Destructor
virtual ~CronDrivenSchedulingAgent() {
}
// Run function for the thread
- uint64_t run(const std::shared_ptr<core::Processor> &processor, const
std::shared_ptr<core::ProcessContext> &processContext, const
std::shared_ptr<core::ProcessSessionFactory> &sessionFactory);
+ utils::ComplexTaskResult run(const std::shared_ptr<core::Processor>
&processor, const std::shared_ptr<core::ProcessContext> &processContext,
+ const std::shared_ptr<core::ProcessSessionFactory> &sessionFactory)
override;
- virtual void stop() {
+ virtual void stop() override {
Review comment:
Virtual functions should specify exactly one of virtual, override, or final.
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
