szaszm commented on a change in pull request #735: MINIFICPP-1158 - Event
driven processors can starve each other
URL: https://github.com/apache/nifi-minifi-cpp/pull/735#discussion_r383869397
##########
File path: libminifi/include/SchedulingAgent.h
##########
@@ -202,7 +138,7 @@ class SchedulingAgent {
std::shared_ptr<core::ContentRepository> content_repo_;
// thread pool for components.
- utils::ThreadPool<uint64_t> thread_pool_;
+ std::shared_ptr<utils::ThreadPool<utils::ComplexTaskResult>> thread_pool_;
Review comment:
Since `ThreadPool` outlives `SchedulingAgent`, I'd go for an observer ptr,
possibly realized as a raw pointer with not null semantics. Maybe
`gsl::not_null<ThreadPool*>` if we're open to using the guideline support
library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
