szaszm commented on a change in pull request #731: MINIFICPP-1096 fix
BackTrace, OOB indexing, tests, appveyor reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/731#discussion_r385808318
##########
File path: libminifi/include/utils/BackTrace.h
##########
@@ -41,20 +42,16 @@ class TraceResolver;
*/
class BackTrace {
public:
- BackTrace() {
- }
- BackTrace(const std::string &name)
- : name_(name) {
+ BackTrace() = default;
+
+ explicit BackTrace(std::string name)
+ : name_(std::move(name)) {
}
- BackTrace(BackTrace &&) = default;
- BackTrace(BackTrace &) = delete;
Review comment:
Making it copyable in addition to being movable doesn't break the previous
promise. We can keep it non-copyable if desired, but I didn't see the point and
since both declarations were wrong I decided to rely on the implicit copy and
move ctors.
Given the above, do you still want to disable copy or change the
description? (I'd just remove the "movable" word.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
