szaszm commented on a change in pull request #744: MINIFICPP-1171 - Fix "%ll"
format strings in log lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/744#discussion_r387615986
##########
File path: libminifi/include/FlowControlProtocol.h
##########
@@ -168,12 +168,12 @@ class FlowControlProtocol {
logger_->log_info("NiFi Server Name %s", _serverName);
}
if (configure->get(Configure::nifi_server_port, value) &&
core::Property::StringToInt(value, _serverPort)) {
- logger_->log_info("NiFi Server Port: [%ll]", _serverPort);
+ logger_->log_info("NiFi Server Port: [%hu]", _serverPort);
Review comment:
Use `PRIu16` from `<cinttypes>` for `uint16_t`. `hu` is meant to be used for
`unsigned short int`, which is not guaranteed to be the same as `uint16_t`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
