szaszm commented on a change in pull request #744: MINIFICPP-1171 - Fix "%ll"
format strings in log lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/744#discussion_r387612847
##########
File path: extensions/mqtt/processors/ConsumeMQTT.cpp
##########
@@ -70,12 +70,12 @@ void ConsumeMQTT::onSchedule(const
std::shared_ptr<core::ProcessContext> &contex
value = "";
if (context->getProperty(QueueBufferMaxMessage.getName(), value) &&
!value.empty() && core::Property::StringToInt(value, valInt)) {
maxQueueSize_ = valInt;
- logger_->log_debug("ConsumeMQTT: Queue Max Message [%ll]", maxQueueSize_);
+ logger_->log_debug("ConsumeMQTT: Queue Max Message [%llu]", maxQueueSize_);
Review comment:
Use `PRIu64` from `<cinttypes>` for `uint64_t`. `llu` is meant to be used
for `unsigned long long int`, which is not guaranteed to be the same as
`uint64_t`. It is not the same on my platform.
The above applies to both changes in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
